Improve operand parsing for more instructions #23875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets ->ptr and other values when the operand points to memory. Partial fix for issue radareorg#23857.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets ->ptr and other values when the operand points to memory.
Partial fix for issue #23857.
Description
As per discussion in #23857, additional instructions now have operands handled.
Some - like rotate and shift instructions - only take memory address in the first operand. Some already had equivalent parsing, e.g.
cmp*instructions are covered by theinscmp()function.This PR doesn't change any of the MMX/SSE/AVX instructions, which need a bit more thought as some take three operands / 128 bit memory pointers etc.
Tests still required.