Automated Resyntax fixes #1449
Open
Automated Resyntax fixes #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `if` expression can be refactored to an equivalent expression using `and`.
This `match` expression can be simplified using `match-define`.
This expression is equivalent to calling the `positive?` predicate.
The `let` expression in this `begin0` form can be extracted into the surrounding definition context.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
This conditional expression can be replaced with a simpler, equivalent expression.
The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`.
This negated `unless` expression can be replaced by a `when` expression.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `for/fold` loop can be simplified by using the `#:when` keyword.
This `let` expression can be pulled up into a `define` expression.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
This `map` operation can be replaced with a `for/list` loop.
This `sort` expression can be replaced with a simpler, equivalent expression.
This use of `format` does nothing.
This `for/fold` loop can be simplified by using the `#:when` keyword.
samth
reviewed
May 2, 2025
| (let ([dom+ (for/fold ([acc '()]) ([dom (in-list dom*)]) | ||
| (if (pair? dom) | ||
| (cons (cdr dom) acc) | ||
| acc))]) |
samth
reviewed
May 2, 2025
| (let ([e (syntax-e args)]) | ||
| (values (car e) (cdr e)))] | ||
| (define e (syntax-e args)) | ||
| (values (car e) (cdr e))] |
There was a problem hiding this comment.
There should be a function that does this.
samth
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 38 issues in 20 files.
single-clause-match-to-match-definelet-to-definefor/fold-with-conditional-body-to-when-keywordcond-let-to-cond-definezero-comparison-to-positive?define-simple-macro-to-define-syntax-parse-ruledefine-let-to-double-definesort-with-keyed-comparator-to-sort-by-keyformat-identityalways-throwing-cond-to-whenmap-to-forif-x-else-x-to-andif-let-to-condinverted-unlessbegin0-let-to-define-begin0if-else-false-to-and