Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2024-10-31-racket-v8-15.md #334

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Conversation

spdegabrielle
Copy link
Member

edited for clarity

@spdegabrielle
Copy link
Member Author

@jbclements I'd like to include images but I'm stumped as to where to put them in the repo
save2htdpImage
restore

@sorawee
Copy link
Contributor

sorawee commented Nov 6, 2024

https://github.com/racket/racket-lang-org/tree/master/blog/img

You can then include an image with ![<caption>](/img/<filename>)

@jbclements
Copy link
Contributor

This pull request looks good, shall i wait until you've added the images, per @sorawee 's instructions?

@spdegabrielle
Copy link
Member Author

@sorawee thank you! I was confused because https://github.com/racket/racket-lang-org/blob/0e88696fc3898b5a0fefc4fc437901ed7336e098/blog/_src/posts/2024-02-08-racket-v8-12.md?plain=1#L9C1-L9C75 references a folder and file that do not appear in the repo

@jbclements images added - ready to go

@spdegabrielle
Copy link
Member Author

@jbclements Ok?

Copy link
Contributor

@jbclements jbclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apologies for the delay!

@sorawee
Copy link
Contributor

sorawee commented Nov 10, 2024

I was confused because https://github.com/racket/racket-lang-org/blob/0e88696fc3898b5a0fefc4fc437901ed7336e098/blog/_src/posts/2024-02-08-racket-v8-12.md?plain=1#L9C1-L9C75 references a folder and file that do not appear in the repo

It's indeed confusing. @jbclements, could you tell what you did exactly, when you published 9784d78? My guess is that you uploaded the image file to S3 directly. Is that the case?

@sorawee sorawee merged commit 1cfb74f into racket:master Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants