OeX_Depr-112 Account pages -> micro-frontend #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyudyunov
approved these changes
May 2, 2022
ruzniaievdm
approved these changes
May 2, 2022
idegtiarov
reviewed
May 2, 2022
.env.development
Outdated
| @@ -1,5 +1,7 @@ | |||
| EXAMPLE_VAR=Example Value | |||
| ACCESS_TOKEN_COOKIE_NAME=edx-jwt-cookie-header-payload | |||
| ACCOUNT_PROFILE_URL=http://localhost:1995/u | |||
There was a problem hiding this comment.
Please clarify why do our URL looks a little bit weird with the suffix /u ?
There was a problem hiding this comment.
I just brought the URL to one view, as in the platform: https://github.com/raccoongang/edx-platform/pull/2419/files#diff-aa3422bb9dd162d0f77ccc8e4f2bd3bfe204f1f3eeb6ecbbf99e7462cf16edb9R338. Should I change it without the suffix? frontend-app-profile has only this valid url: /u/:username and error url /notfound.
There was a problem hiding this comment.
I would prefer we have all URLs in a consistence way so our settings should be mapped to certain services. An appropriate URL should be built on the base_service_url + API URL as we usually do.
UvgenGen
force-pushed
the
depr/account-pages
branch
from
4940163 to
4952ecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OeX_Depr-112 Account pages -> micro-frontend
openedx/public-engineering#71