v4.1.x consistent logging (with ?LOG_MACROs) #14445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's added automatically by logger
`?RMQLOG_DOMAIN_GLOBAL` used to be added by a now deleted logging module rabbit_log.
Some community plugins use rabbit_log. To simplify the transition, we can keep this module as a simple wrapper on logger macros.
The continuation lines in multi-line LOG macro calls should align with the opening quote character of the format string.
Fixed alignment in: - amqp_channel.erl: 3 instances - amqp_gen_connection.erl: 2 instances - rabbit_fifo_client.erl: 2 instances Continuation lines now properly align with the opening quote.
mkuratczyk
force-pushed
the
v4.1.x-consistent-logging
branch
from
822453f to
e73955a
Compare
mkuratczyk
changed the title
|
I agree, the only reason for backporting #14232 is to avoid conflicts in many other PRs, both present and future ones, because logging touches every subsystem and every module. Thank you! |
michaelklishin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14232 for v4.1.x.
There were many conflicts so it's not a straightforward backport. Some automation
was used to resolve conflicts. Some indentation is wrong, but hopefully we can ignore this
(it's good, or at least better, on
main).For the record, I don't feel great about backporting these changes. :)
But if it's hard to backport anything else because of that, I guess we can do this.