-
Notifications
You must be signed in to change notification settings - Fork 3.9k
OAuth2: support opaque tokens #13978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MarcialRosales
wants to merge
34
commits into
main
Choose a base branch
from
feature-8662
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe04c36
to
7c59322
Compare
1e50258
to
9605c96
Compare
cd6087c
to
6cd7bd7
Compare
There is still an issue mapping client_auth_method
And add client used to introspect tokens
so that it is possible to test with clients configured with opaque tokens and others with jwt tokens
Refactoring needed so that the resolved jwt token is kept in the management ui so that the backend does not need to reoolve it permanentely
Rather than configuring the type of token, the server is able to detect if the token is jwt or not
so that management can cache the jwt token resulting from introspecting an opaque one
related to accepted content type
d23826e
to
9b275c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implements #8662
RabbitMQ will never cache the resolved JWT access token. it will only be cached for the duration of the session/connection. Once RabbitMQ resolves the JWT access token (i..e exchanged the opaque one for a JWT one), it will work as usual, i.e. it will use the expiry date in the resolved JWT access token.
Tasks:
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply