feature_flags_SUITE: Change clustering seed node in few tests #13232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] Some testcases used to use node 1 as the clustering seed node. With mixed-version testing, it could cause issues because node 1 would start with a new version of Ra compared to node 2 and node 2 could fail to join. [How] By using node 2 as the seed node, node 1 running a newer version of Ra should be able to join because it supports talking to an older version.
michaelklishin
pushed a commit
that referenced
this pull request
Feb 12, 2025
…khepri-0.17.0 feature_flags_SUITE: Change clustering seed node in few tests (cherry picked from commit 55ae918)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some testcases used to use node 1 as the clustering seed node. With mixed-version testing, it could cause issues because node 1 would start with a new version of Ra compared to node 2 and node 2 could fail to join.
How
By using node 2 as the seed node, node 1 running a newer version of Ra should be able to join because it supports talking to an older version.