-
Notifications
You must be signed in to change notification settings - Fork 604
Pipeline improvements #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…he pipes and using pooled buffers for inbound frames.
…ask that's only triggered when needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Please remove the test program. Publishing it in a separate repo under your account should be sufficient.
Please rebase this against master. Out of curiosity, do most of the gains come from the switch to |
@Anarh2404 thanks for this pull request. We can't merge this pull request as-is into Or, @stebet - would you mind reviewing these changes and, if acceptable, merge them into your |
@stebet - and by "these changes" I mean the changes in @Anarh2404 's commit: 3147ab5 |
I'll take a look tomorrow :) |
@michaelklishin @lukebakken @stebet I think it would be nice if this PR would be merged into a |
Made a test branch where i merged this PR and #732 :) |
@michaelklishin test program from the #706 |
I am assuming that the changes in this PR will be investigated for version |
Proposed Changes
This PR based on awesome @stebet work in #706
I made some improvements and achieved even greater reduction in memory consumption and increased performance.
Here is what I did:
All tests run, except for the APIApproval
Types of Changes
Checklist
CONTRIBUTING.md
documentFurther Comments
I added netstandard2.1 and few #if derectives, because some perf critical API is only available in the netstandard2.1/netcoreapp3.0. For netstandard2.0 and net461 added fallback to a less optimal implementation.
Memory test
512byte payload


#706
This PR
Simple perfomance test on my home pc
1 publisher, 1 consumer, no ack



Nuget 5.1.2
#706
This PR
1 publisher, 1 consumer, manual ack, 64 prefetch count



Nuget 5.1.2
#706
This PR