Skip to content

Conversation

tyb-dev
Copy link

@tyb-dev tyb-dev commented Sep 5, 2025

Proposed Changes

This allows clients to send the full intermediate chain during the TLS handshake instead of relying on OS stores or AIA fetches, addressing issue #1864. It improves interoperability when servers don’t have intermediates installed or when environments lack internet access.
Keep behavior unchanged for netstandard2.0; the new API is only compiled for net8.0.
Split Public API “Unshipped” files per TFM and wire them via AdditionalFiles to satisfy the PublicApiAnalyzer for both net8.0 and netstandard2.0.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

N/A

@tyb-dev
Copy link
Author

tyb-dev commented Sep 5, 2025

I haven't signed the CA yet. If there's interest in this change, I'm happy to sign it so this PR can proceed.

@michaelklishin
Copy link
Contributor

@tyb-dev I definitely think there is interest in supporting this option (conditionally, on .NET 8+). Thank you!

Please email us as described in the contributor CLA repo and we will send you a Box Sign signature request.

@lukebakken lukebakken self-requested a review September 5, 2025 16:43
@lukebakken lukebakken self-assigned this Sep 5, 2025
@lukebakken lukebakken added this to the 7.2.0 milestone Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants