Skip to content

Support ArraySegment bodies in BasicPublish #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Astomat opened this issue Jan 5, 2017 · 4 comments
Closed

Support ArraySegment bodies in BasicPublish #303

Astomat opened this issue Jan 5, 2017 · 4 comments
Labels
enhancement next-gen-todo If a rewrite happens, address this issue.

Comments

@Astomat
Copy link

Astomat commented Jan 5, 2017

Hello,
It will be very helpful to have the ability to receive ArraySegment body in BasicPublish method.
I have many cases in which memory needs to copied in order to build the proper body byte array instead of just defining a segment in byte array buffers.
Another posibility is to accecpt offset and length in addition to body byte array.

Thanks,
Astomat

@michaelklishin michaelklishin changed the title Ability to use ArraySegment in BasicPublish Support ArraySegment bodies in BasicPublish Jan 5, 2017
@michaelklishin
Copy link
Contributor

@kjnilsson sounds like a new override we can safely introduce? thoughts?

@kjnilsson
Copy link
Contributor

Sounds like a good idea. There may be a few changes to make for this but definitely worth investigating.

@stebet
Copy link
Contributor

stebet commented Feb 21, 2020

It would be smart to also allow using Memory. To utilize memory pooling/recycling efficiently another one using IMemoryOwner (supported in the System.Memory NuGet packages for .NET Framework) making it possible to often avoid memory copies (almost entirely when pipelines are introduced) when publishing.

@lukebakken
Copy link
Collaborator

I think it's safe to assume that #706 and other improvements in version 7.0.0 will address this issue.

@lukebakken lukebakken removed this from the 6.0.0 milestone Mar 16, 2020
@lukebakken lukebakken added next-gen-todo If a rewrite happens, address this issue. and removed effort-tiny labels Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement next-gen-todo If a rewrite happens, address this issue.
Projects
None yet
Development

No branches or pull requests

5 participants