Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow force shrink to non-voter member #530

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

anhanhnguyen
Copy link
Contributor

Hi,

We recently tested the force shrink operation to a single member and found that it is currently not possible to shrink to a non-voter member. However, we think that in disaster recovery scenarios, it should be reasonable to recover from any member, whether a voter or non-voter.

Proposed Changes

Allow force shrink to a non-voter member, as it can be the only surviving member in a disaster recovery scenario.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@kjnilsson kjnilsson self-requested a review March 28, 2025 09:04
Copy link
Contributor

@kjnilsson kjnilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable change. Thank you. Just a formatting comment.

@anhanhnguyen anhanhnguyen force-pushed the force-shrink-to-non-voter branch from c05abb9 to 76572df Compare March 28, 2025 09:39
@kjnilsson kjnilsson merged commit 2a66f2b into rabbitmq:main Mar 28, 2025
3 checks passed
@michaelklishin michaelklishin added this to the 2.16.6 milestone Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants