-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Experimental/phpdocumentor #3
Open
r4j4h
wants to merge
12
commits into
master
Choose a base branch
from
experimental/phpdocumentor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not like how many dependencies it requires, but can't find a good alternative.
* master: Stubbing out more classes Forgot to include IndexTaskParameters Handling aggregations in SimpleIndexGenerator Expanding test criteria for SimpleIndexGenerator Stubbing intended use Updating some docblocks
* master: Mocking writeFile so that test does not actually cause IO Finishing unit tests Lots of cleanup, testing, docblocks, and refactoring Updating php-druid-query and reworking IndexTaskQueryParameters to use the newly introduced Interval class Removing old busted queries Simplifying ingest() Fixing druid-connection config Major class/interface refactoring README update Re-sketching now that php-druid-query is up to par Writing tests Moving druid node connection info out to config file Added php-druid-query as a dependency Updating references and some unit tests Sketching some interface redesigns Conflicts: composer.lock vendor/autoload.php vendor/composer/autoload_psr4.php vendor/composer/autoload_real.php vendor/composer/installed.json
* master: Adding phing via composer and providing a default task that runs phpunit and generates a coverage report in /build artifact folder. Conflicts: .gitignore composer.json composer.lock vendor/autoload.php vendor/composer/autoload_classmap.php vendor/composer/autoload_real.php
* master: Removing Grunt support in favor of Phing to keep this PHP project more PHP based. Conflicts: Gruntfile.js package.json
* master: Adding autoloader tag to build.xml for clarity and ensuring composer compatibility Conflicts: build.xml
* master: Adding php mess detector and php loc, setting up build artifact output through phing Conflicts: build.xml composer.json composer.lock vendor/autoload.php vendor/composer/autoload_namespaces.php vendor/composer/autoload_real.php
# Conflicts: # composer.json # composer.lock # vendor/autoload.php # vendor/composer/autoload_classmap.php # vendor/composer/autoload_namespaces.php # vendor/composer/autoload_psr4.php # vendor/composer/autoload_real.php # vendor/composer/installed.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rudimentary but functional.
Output can be seen here.
Todo:
react/promise
orbcncommerce/json-stream
are needed here and remove if notphing report
docs/
mv docs/* ./
from root