Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add passthrough for keep_units() when units are not provided #394

Merged
merged 7 commits into from
Feb 25, 2025
Merged

add passthrough for keep_units() when units are not provided #394

merged 7 commits into from
Feb 25, 2025
+61 −1

Conversation

d-morrison
Copy link
Contributor

@d-morrison d-morrison commented Feb 14, 2025 •
edited
Loading

fixes #392

@d-morrison d-morrison changed the title fixes #392 add passthrough for keep_units() when units are not provided Feb 14, 2025
@d-morrison d-morrison mentioned this pull request Feb 14, 2025
Closed
@d-morrison d-morrison marked this pull request as ready for review February 14, 2025 10:32
@d-morrison
Copy link
Contributor Author

@Enchufa2 I think this covers all the cases we discussed in #392? Hope it's helpful; feel free to discard if not.

Enchufa2
Enchufa2 requested changes Feb 15, 2025
View reviewed changes
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding some details about this usage to the documentation of the function? Also maybe some examples about this random generation with days, years, rates...

@Enchufa2
Copy link
Member

@d-morrison Kind reminder. :)

@d-morrison
Copy link
Contributor Author

@d-morrison Kind reminder. :)

@Enchufa2 apologies for the delay! The past week was rough. Working on it today!

@d-morrison d-morrison requested a review from Enchufa2 February 24, 2025 21:53
Enchufa2
Enchufa2 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Enchufa2 Enchufa2 merged commit 9e6502e into r-quantities:main Feb 25, 2025
7 checks passed
@d-morrison d-morrison deleted the keep_units-no-units branch February 25, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enchufa2 Enchufa2 Enchufa2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keep_units() with non-units x input
2 participants
@d-morrison @Enchufa2