Fix package_hooks_linter to validate .onUnload() arguments
#2964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 129 129
Lines 7282 7282
=======================================
Hits 7227 7227
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emmanuel-ferdman
force-pushed
the
main
branch
from
3011d78 to
905bddb
Compare
| rex::rex(".onUnload() should take one argument starting with 'lib'."), | ||
| linter | ||
| ) | ||
| expect_lint( |
There was a problem hiding this comment.
use expect_no_lint here
There was a problem hiding this comment.
Right, fixed 🙌
|
thanks! basically LGTM. please link the R source of how this is enforced in the PR description for future reference |
Signed-off-by: Emmanuel Ferdman <[email protected]>
emmanuel-ferdman
force-pushed
the
main
branch
from
905bddb to
c742504
Compare
|
Oh, @emmanuel-ferdman, thanks for the link. Actually, what I had in mind is: But, it turns out that's not currently enforced by |
MichaelChirico
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes
package_hooks_linterto properly validate.onUnload()hook signatures. Previously, the linter would silently ignore.onUnload()functions with missing or incorrect arguments, butR CMDcheck requires.onUnload()to take exactly one argument starting with 'lib' (like libpath). The fix adds.onUnloadto the existing argument validation logic that was already checking.onDetach()and.Last.lib().R source reference for
.onUnload(libpath): https://github.com/wch/r-source/blob/97f6c68d5856ecc2257867e89bc870d7e49a8da8/src/library/base/R/namespace.R#L881-L892Fixes #2940.
Related: #2737