Add a generic for table #209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
As well as in #189 the |
hcirellu
added a commit
to hcirellu/bit64
that referenced
this pull request
Jan 5, 2026
hcirellu
added a commit
to hcirellu/bit64
that referenced
this pull request
Jan 5, 2026
This reverts commit e9ad587.
Contributor
Author
|
As soon as PR #227 is merged the checks with calling |
| table = function(..., exclude=if (useNA == "no") c(NA, NaN), useNA=c("no", "ifany", "always"), dnn=list.names(...), deparse.level=1L) UseMethod("table") | ||
| #' @exportS3Method table default | ||
| table.default = function(..., exclude=if (useNA == "no") c(NA, NaN), useNA=c("no", "ifany", "always"), dnn=list.names(...), deparse.level=1L) { | ||
| if (...length() && any(unlist(lapply(list(...), is.integer64)))) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (...length() && any(unlist(lapply(list(...), is.integer64)))) { | |
| if (...length() && vapply(list(...), is.integer64, logical(1L))) { |
| ) | ||
| } | ||
| } | ||
| choose_sys_call = function(function_names, name_to_display=NULL) { |
Collaborator
There was a problem hiding this comment.
let's move it to zzz.R to make the diff clearer, if any
| #' @exportS3Method table default | ||
| table.default = function(..., exclude=if (useNA == "no") c(NA, NaN), useNA=c("no", "ifany", "always"), dnn=list.names(...), deparse.level=1L) { | ||
| if (...length() && any(unlist(lapply(list(...), is.integer64)))) { | ||
| withCallingHandlers({ |
Collaborator
There was a problem hiding this comment.
this can be replaced too, right?
| stop(errorCondition(gettext("all arguments must have the same length", domain="R-base"), call=choose_sys_call(c("table", "table.integer64")))) | ||
| if (!is.integer64(a)) { | ||
| warning("coercing argument ", i, " to integer64") | ||
| warning(warningCondition(paste0("coercing argument ", i, " to integer64"), call=choose_sys_call(c("table", "table.integer64")))) |
Collaborator
There was a problem hiding this comment.
Is it required to do this? e.g., it breaks table(x, y) for y a string.
We can mark this as a follow-up, checking your thoughts here first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A generic for table is added. The
table.defaultchecks the arguments in..., whether it containsinteger64. If so,table.integer64is called. Otherwisebase::tableis called.In
table.defaultthe warnings und errors of underlying methods are captured and recreated to display nice condition messages.table.integer64is not exported anymore.sortcache,sortordercacheandordercachehave a new argumentna.lastin order to havetable.integer64consistent tobase::tablewhen it comes toNAvalues.table.integer64has two new argumentsexcludeanduseNAto be consistent withbase::table.Where possible the translation of base-R is used for condition messages.
I added a helper function
choose_sys_call()to determine the desired sys.call to be used in the condition messages.Closes #59