-
Notifications
You must be signed in to change notification settings - Fork 12
Overhaul seq() to be more full-featured and less buggy #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Here are the 47 failures of the updated suite on Details |
Collaborator
Author
|
Analysis (using Here are changes to error cases on
Here are changes to actual output values: seq.integer64() would ignore from/to for an implied constant sequence of specified length:one = as.integer64(1)
seq(1, 1, length.out=10) # rep(1, 10)
seq(one, one, length.out=10) # main: 1LL:10LL; this branch: rep(1LL, 10L)seq.integer64() would ignore length.out=0## two arguments
seq(to=5, length.out=0) # integer()
seq(to=as.integer64(5L), length.out=0) # main: 1LL:5LL; this branch: integer64()
## three arguments
seq(5, 4, length.out=0) # integer()
seq(one, 2, length.out=0L) # main: 1LL:2LL; this branch: integer64()seq.integer64(to = 0LL) gives empty outputseq(to = 0) # 1:0
seq(to = as.integer64(0L)) # main: integer64(); this branch: 1LL:0LL |
Collaborator
Author
|
Need some more tests for double inputs: seq(as.integer64(1), 20, by=1.5)
## main
# integer64
# [1] 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
## this PR
# integer64
# [1] 1 2 3 4 5 6 7 8 9 10 11 12 13 |
Also more skipped cases, for now, related to mixed integer64+double arithmetic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47
(committed by mistake directly to
main: a51cf9d)