Fix g++ rpp errors #401
Merged
Fix g++ rpp errors #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-abishek
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Hope all QA tests are passing for U8 - CI to validate.
@Srihari-mcw Since changes are mostly in F32 variants of functions, please run in unit test mode for the variants affected and validate visual output of images look fine.
| h1 = _mm_loadu_si128((__m128i *)srcPtrTempH); | ||
| h2 = _mm_loadu_si128((__m128i *)srcPtrTempS); | ||
| h3 = _mm_loadu_si128((__m128i *)srcPtrTempV); | ||
| h1 = _mm_loadu_ps((float*)srcPtrTempH); |
There was a problem hiding this comment.
Is srcPtrTempH always passed in float?
| @@ -385,7 +385,7 @@ RppStatus glitch_f32_f32_host_tensor(Rpp32f *srcPtr, | |||
| __m256 p; | |||
| compute_src_loc(dstLocRow, vectorLoopCount, glitchSrcLocArray, srcDescPtr, rgbOffsets, roi, batchCount, 3); | |||
| rpp_simd_load(rpp_glitch_load6_f32pkd3_to_f32pkd3_avx, srcPtrChannel, glitchSrcLocArray, p); | |||
| _mm256_storeu_si256((__m256i *)(dstPtrTemp), p); | |||
| _mm256_storeu_ps(dstPtrTemp, p); | |||
There was a problem hiding this comment.
This could have been a bug - storing __m256i instead of __m256 for glitch f32?
| pRow[7] = avx_px0; | ||
| pRow[8] = avx_px0; | ||
| pRow[6] = avx_p0; | ||
| pRow[7] = avx_p0; |
There was a problem hiding this comment.
Interesting clang++ did not catch that.
|
Checked samples from glitch, warp_perspective, log, resize, gaussian filter and also color_convert from batch_pd. All samples match with images without changes in PR. Thanks |
r-abishek
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to fix simd instruction related issues that are encountered specifically with g++ as compiler for RPP. Thanks