RPP Normalize - 1D kernel Optimization #351
Conversation
Dineshbabu-Ravichandran
commented
Oct 16, 2024
Dineshbabu-Ravichandran
commented
- Optimized Normalize 1D for f32 and u8 bit depth using SIMD instructions
| @@ -88,6 +88,13 @@ void fill_roi_values(Rpp32u nDim, Rpp32u batchSize, Rpp32u *roiTensor, bool qaMo | |||
| { | |||
| switch(nDim) | |||
| { | |||
| case 1: | |||
| { | |||
| std::array<Rpp32u, 2> roi = {0, 10000}; | |||
There was a problem hiding this comment.
Does std::array needs any includes to be added?
There was a problem hiding this comment.
I think It need #include to be included . But I am not sure where it is included .
There was a problem hiding this comment.
In your environment you might not get the issue when it is not included, in the CI the build will get failed if it is not included in some environments
There was a problem hiding this comment.
I am following the same approach how they previous used for case 2 and case 3. Is that is Okay ?
| rppt_normalize_host(inputF32, srcDescriptorPtrND, outputF32, dstDescriptorPtrND, axisMask, meanTensor, stdDevTensor, computeMeanStddev, scale, shift, roiTensor, handle); | ||
|
|
||
| if(bitDepth == 0) | ||
| rppt_normalize_host(inputU8, srcDescriptorPtrND, outputU8, dstDescriptorPtrND, axisMask, meanTensor, stdDevTensor, computeMeanStddev, scale, shift, roiTensor, handle); |
There was a problem hiding this comment.
Why the u8 calls are addded here . you have added the same calls in both audio and image test suites. Please remove the changes for u8 if it is not needed
| @@ -372,6 +385,48 @@ int main(int argc, char **argv) | |||
|
|
|||
| break; | |||
| } | |||
| case 8: | |||
There was a problem hiding this comment.
please add the support in HIP test suite as well
src/modules/cpu/kernel/normalize.hpp
Outdated
|
|
||
| Rpp32u totalElements = 1; | ||
| Rpp32u lastNormAxis = 0; | ||
| Rpp32u axis[tensorDims], newAxis[tensorDims], newDims[tensorDims]; |
There was a problem hiding this comment.
you are doing static allocations here. This might cause some issue . please use the scratch buffer available in the host handle
