Skip to content

Conversation

lfroes
Copy link
Contributor

@lfroes lfroes commented Apr 8, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Resolved #245, created compatibility with nx: 20.7.1.

The current issue was happening because of the ensureProjectName function, now that nx has updated and this does not work like used to do.

I Have done quick fix so the package can be used with the nx 20.7.1, still need some advice on how to make it work when the user do not use the --name flag with the command, maybe create a default name like myAppand myLib?

Use cases and why

Actual behavior:

  • When using nx 20.7.1 we are unable to generate new apps or libs

Expected behavior:

  • using nx generate qwik-nx:app should work with nx 20.7.1

Screenshots/Demo

N/A

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@lfroes lfroes changed the title FIX #245 FIX #245: Error while running nx generate qwik-nx:app Apr 8, 2025
Copy link

pkg-pr-new bot commented May 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/qwikifiers/qwik-nx@246

commit: ba37969

@dmitry-stepanenko
Copy link
Contributor

Hey @lfroes thanks for your PR and patience 😄

I've pushed a small enhancement on top

@dmitry-stepanenko dmitry-stepanenko merged commit 2dc8106 into qwikifiers:main May 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while trying to run nx generate qwik-nx:app
2 participants