Feat/linspace measurements reversed registers divisor #901

Nomos11 · 2025-07-01T09:39:35Z

just to see how experimental branch differs

for freeing up register(<->depkey) once loop ends

shumpohl · 2025-07-01T09:42:49Z

qupulse/examples/expectation_checker.py

Move to root examples directory

shumpohl · 2025-07-01T09:42:58Z

qupulse/examples/expectation_checker_example_script.py

Move to root examples directory

shumpohl · 2025-07-01T09:44:03Z

qupulse/expressions/simple.py

Looks good.

I reconsidered and remembered I did not put them there for a reason. The idea is that SimpleExpressions are more like context sensitive numbers than expressions.

I only needed to move them due to some circular import otherwise i believe. The name might indeed be misleading

shumpohl · 2025-07-01T09:48:45Z

qupulse/hardware/awgs/base.py

We should move most program specific stuff out of here

shumpohl · 2025-07-01T09:49:27Z

qupulse/hardware/dacs/alazar.py

shumpohl · 2025-07-01T10:03:40Z

qupulse/program/transformation.py

+                parsed.extend(t.transformations)
+            else:
+                parsed.append(t)
+        self._transformations = tuple(parsed)


use chain_transformations or Transformation.chain instead. Or is there a reason you can't?

I vaguely remember contemplating to do that or attempting to do that, but uncertain if it did not work for some reason or I just forgot to try it

I will resolve this by adding documentation that you should not construct ChainedTransformation directly

shumpohl · 2025-07-01T10:05:53Z

qupulse/program/waveforms.py

+        """
+
+    def _hash_only_subset(self, channel_subset: Set[ChannelID]) -> int:
+        """Return a hash value of this Comparable object."""


I believe this was to further optimize waveform deduplication; i.e. try to reuse waveform data already sampled for one channel for another one. Otherwise the comparison included the channel name which prevented reusage across channels I believe.

The performance increase was minimal and noticeable only in specifically constructed examples, which means it is probably unnecessary

shumpohl · 2025-07-01T10:10:51Z

qupulse/program/waveforms.py

+
+
+
+class WaveformCollection():


What is the purpose?

This also was for the "nested stepping", to have a collection of waveforms in a nested structure at hand that would be iterated over with the command table indices

qupulse/pulses/repetition_pulse_template.py

shumpohl · 2025-07-01T10:14:06Z

qupulse/pulses/time_reversal_pulse_template.py



+class AtomicTimeReversalPulseTemplate(AtomicPulseTemplate):


Is this still required?

I'm not sure; i vaguely remember @maxbeer99 requesting some time reversal features for the T-junction and this was somehow the easiest way to do it, but I'd need to look into the usecase again

Ths was probably before the to_single_waveform kwarg was introduced

There may have been some other reason i need to think about again

no valid reason comes to my mind now so this can probably be discarded

shumpohl · 2025-07-01T10:20:53Z

My estimate is that the changes that are not directly in linspace.py are roughly a day of work to incorporate into the master branch. Those are:

The examples (move to hdawg driver)
Treating simple expression as a proper expression somehow
- move to expression (trivial)
- Transformation changes. Here we need to evaluate transformations that contain hardware dependent exprssions. Right now these are by default assumed to be the neutral element of the corresponding operation. The programbuilder is responsible for enusring that this assumption does not brek the program. However this code breaks if the TransformingWaveform is nested.
Waveform changes (need to understand reasoning and motivation)
pad_all_atomic_subtemplates_to -> add map_subtemplates function
...

Nomos11 · 2025-07-25T11:10:35Z

Nomos11 added 30 commits May 31, 2024 14:42

linspace time sweep barebone test

1132ee1

barebone test for pulse metadata

4d2fdb9

equality handling SimpleExpression; file refactor

7cfcb74

supply __lt__ as well to be logically consistent

74eb4d7

implement dummywaveform abstract compare subset

f595806

tests

bc985cd

Update setup.cfg

627a27f

delete wrong decorator

06aa1b3

somewhat fix the tests

f87b1ea

uncomment imports

e6b1e9e

forward voltage increment resolution

3c65a9c

wrongly assumed hardware resolution

634cd30

draft dependent waits & dependency domains

7d6b01a

first syntactic debug

1ea5176

fix definition of iterations

37ee51d

see if one can replace int->ChannelID

b37b510

fix channel trafo call

c796b61

fix transform commands

6d4e835

resolution dependent set/increment

9fd050c

remove outdates resolution handling attempt

051e8b9

math methods for resolution class

e58277c

fix domain check

cf74051

fix __mul__

2447e23

test wf amp sweep

a9f1710

bugfix

d9dad64

not sure if correct (depstate comparison)

5f22a52

fix some of the depkey confusion

b04cbcf

more flexible repetition in sequence structure

e4c2366

dependency_key -> key for consistency

f250226

always emit incr/set before wait

e84ecf8

Nomos11 added 14 commits December 13, 2024 15:58

also on creation

55a4e6b

simon's reversed loopbuilder

f93e02f

potentially working LinSpaceBuilder reversal

6d78bec

measurement reversed (without t-sweep)

ec18543

include loop idx in depkey

60d493f

for freeing up register(<->depkey) once loop ends

include loop idx at which depkey **should** be freed

0d377c1

disable print

30dfecb

wrong indent level; remove print

2e8c9c9

revert comparison yet again

3d2c634

need to pop

224907e

waveformcollection duration

88f64c2

why was this not noticed before

a0b1194

power 2 hack

4cbc158

SH's sympy fix from main

88faf7b

shumpohl reviewed Jul 1, 2025

View reviewed changes

shumpohl mentioned this pull request Jul 1, 2025

Plotting constant deduplication #903

Open

Nomos11 added 12 commits July 3, 2025 19:57

update typehint for change in qupulse-hdawg

8ed592c

further explanation

1b299e7

ooon

d88f45d

fix(?)/hack in measurements in rep/iter/sequence

461202b

? git missed something

2fbb63a

interestingly not seen before

e8337e2

roll out time sweeps in linspacebuilder

88740ba

optionally roll out other vars

f6e66c5

propagation

0d25a97

optionally concatenate sequential wfs based on duration

457a7d0

bracket required - Chil Pollins

a9822d7

mutable default

c539dad




		class WaveformCollection():



		class AtomicTimeReversalPulseTemplate(AtomicPulseTemplate):

Feat/linspace measurements reversed registers divisor #901

Are you sure you want to change the base?

Feat/linspace measurements reversed registers divisor #901

Conversation

Nomos11 commented Jul 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nomos11 Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nomos11 Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shumpohl commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nomos11 commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Nomos11 Jul 2, 2025 •

edited

Loading

Nomos11 Jul 1, 2025 •

edited

Loading

shumpohl commented Jul 1, 2025 •

edited

Loading

Nomos11 commented Jul 25, 2025 •

edited

Loading