-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-legacy namespace package #127
Conversation
@bertsky
|
Indeed. I thought I had tested thoroughly. For the moment I'm puzzled. |
The strangest thing of all is that these imports actually do work, but not in the entrypoint: >>> from qurator.eynollah.cli import main
>>> main
<Command main>
|
ah, found it – will need to update the other PRs as well ... |
@bertsky I believe we have made a mistake, and this PR should not be merged. The problem lies with the current setup file; eynollah still fails to find the qurator module. The reason for my initial justification is that if you have installed eynollah with a working setup file and then pull the new commits, you won't encounter the issue because the old installation has already created a correct SOURCES.txt file. However, if you delete the 'eynollah.egg-info' and 'build' directories and try to install eynollah with the latest setup file, you will encounter the problem. |
I just tried afresh (new clone, new venv) from main. With With
Perhaps you have some of the other packages in |
Yes you are right. With pip install -e . works. Thank you. |
The current legacy approach to namespace packaging does not work with development/editable installation. See OCR-D/ocrd_all#433
This PR fixes it for this package – analogous PRs to the other qurator repos will follow.