Merge notable count from the server during sync #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the following case: * The user has disabled notifications for messages in their push rules. * There is no room-specific override for notifications in the push rules. In libQuotient applications - despite being asked to not to - will still add new unread messages to the notable count. This does not happen in other clients, e.g. Element. So now the notable count is used from the server which is correct as it takes into account the push configured by the user.
|
hmm, I think this causes some asserts to trip still :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the following case:
In libQuotient applications - despite being asked to not to - will still add new unread messages to the notable count. This does not happen in other clients, e.g. Element. So now the notable count is used from the server which is correct as it takes into account the push configured by the user.