Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join rule event #862

Merged
merged 6 commits into from
Feb 10, 2025
Merged

Join rule event #862

merged 6 commits into from
Feb 10, 2025

Conversation

nvrWhere
Copy link
Collaborator

Upstream join rule event from neochat

@nvrWhere nvrWhere requested a review from KitsuneRal January 26, 2025 17:07
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM except a couple of technical things.

@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Feb 3, 2025
@nvrWhere nvrWhere requested a review from KitsuneRal February 9, 2025 12:33
KitsuneRal
KitsuneRal previously approved these changes Feb 10, 2025
@KitsuneRal KitsuneRal merged commit fe1f64d into dev Feb 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for the library
Projects
Status: 0.10 - Done
Development

Successfully merging this pull request may close these issues.

2 participants