Downsampling #27
Open
Downsampling #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 30, 2025 12:00
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (6)
- Downsampling/dockerfile: Language not supported
- Downsampling/requirements.txt: Language not supported
- grafana/dashboards/sensors.json: Language not supported
- raw-to-table/requirements.txt: Language not supported
- raw-to-table/main.py: Evaluated as low risk
- fleet-console-web-sockets/main.py: Evaluated as low risk
Comments suppressed due to low confidence (1)
Downsampling/main.py:9
- The environment variable 'window_size_s' is used without validation. Ensure it is a valid integer before using it.
window_size_s = os.environ["window_size_s"]
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated 2 comments.
Files not reviewed (6)
- Downsampling/dockerfile: Language not supported
- Downsampling/requirements.txt: Language not supported
- grafana/dashboards/sensors.json: Language not supported
- raw-to-table/requirements.txt: Language not supported
- raw-to-table/main.py: Evaluated as low risk
- fleet-console-web-sockets/main.py: Evaluated as low risk
Comments suppressed due to low confidence (3)
Downsampling/main.py:9
- The environment variable 'window_size_s' is accessed directly without validation. This can cause runtime errors if the variable is not set or is not an integer. Add a validation check to ensure 'window_size_s' is set and is a valid integer.
window_size_s = os.environ["window_size_s"]
Downsampling/downsampling.py:38
- Ensure that the key 'end' exists in the 'window' dictionary before accessing it to avoid a KeyError.
"timestamp": int(window["end"] * 1E6)
Downsampling/downsampling.py:41
- Ensure that the key 'value' exists in the 'window' dictionary before accessing it to avoid a KeyError.
for key, value in window["value"].items():
| value: sensor-data-1s | ||
| - name: window_size_s | ||
| inputType: FreeText | ||
| description: '' |
There was a problem hiding this comment.
The description for 'window_size_s' is empty. Please provide a clear description.
Suggested change
| description: '' | |
| description: 'Size of the time window in seconds for downsampling.' |
| @@ -0,0 +1,48 @@ | |||
|
|
|||
There was a problem hiding this comment.
Remove the empty lines at the beginning of the file.
Suggested change
| def reduce_window(window:dict, row: dict): |
added 2 commits
February 18, 2025 14:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.