Fiber cleanup fixes #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A transcription of https://slack-github.com/slack/react/compare/v16.11.0; however, Quip's version of React has ReactFiberCommitWork.new.js and ReactFiberCommitWork.old.js. The old.js files required adding commitUnount implementations for other React HostConfigs (Noops seemed to be fine for all of them). TODO: 1. Verify this fixes the fiber leak: https://app.slack.com/client/T5J4Q04QG/threads?multi_team=1#:~:text=to%20have%20a-,fiber%20leak,-that%20also%20holds
|
I suspect we only have to update the old code path since the new is only enabled behind a flag, but doesn't hurt either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A transcription of
https://slack-github.com/slack/react/compare/v16.11.0; however, Quip's version of React has ReactFiberCommitWork.new.js and ReactFiberCommitWork.old.js. The old.js files required adding commitUnount implementations for other React HostConfigs (Noops seemed to be fine for all of them).
To test these changes: https://github.com/quip/quip/blob/master/static/js/ext/react/README.quip.md
TODO: