Skip to content

Conversation

@kndehaan
Copy link
Contributor

@kndehaan kndehaan commented Jan 14, 2026

Description

This PR correct the wind curves of nl2023 to sum to 1/3600. This was not the case before, which resulted in a mismatch between electricity sankey demand and supply queries, part of mechanical turk spec electricity_sankey_spec.

Goes with https://github.com/quintel/etdataset/pull/1076

Type of change

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

Related Issues

Closes part of #3405 (only the imbalance of a blank nl2023 scenario).

@kndehaan
Copy link
Contributor Author

Ok I'm really struggeling with getting the curves to sum to 1/3600.

With the current changes, I get correct results:

EACH(
  Q(turk_electricity_sankey_demand),
  Q(turk_electricity_sankey_supply),
  V(energy_power_wind_turbine_offshore,output_of_electricity),
  SUM(V(energy_power_wind_turbine_offshore,electricity_output_curve))*MJ_PER_MWH,
  V(energy_power_wind_turbine_inland,output_of_electricity),
  SUM(V(energy_power_wind_turbine_inland,electricity_output_curve))*MJ_PER_MWH,
)
image

But according to semaphore, they don't add to 1/3600. So when I open the curves in excel and correct the last value of the curves to sum to 1/3600 minus the sum of the other values, the results deviate again:

image

Perhaps this has something to do with that I'm now allowing the max decimals allowed in excel. I will try to use less decimals to see if this fixes it.

@kndehaan kndehaan marked this pull request as draft January 14, 2026 19:21
@mabijkerk
Copy link
Member

@kndehaan maybe it helps to circumvene Excel entirely and use Python.

@kndehaan
Copy link
Contributor Author

The changes in this PR and the final solution have been added to #3403.

@kndehaan kndehaan closed this Jan 15, 2026
@kndehaan kndehaan deleted the nl2023-wind-curves branch January 15, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants