Merged
Conversation
3 tasks
aaccensi
force-pushed
the
update-ruby3.4
branch
9 times, most recently
from
ceed0f7 to
7334ad0
Compare
This was referenced Mar 4, 2026
3 tasks
noracato
approved these changes
Mar 19, 2026
Member
noracato
left a comment
noracato
left a comment
There was a problem hiding this comment.
Works like a charm, nicely done!
There are some gems that can go, and puma could be bumped. But we can make issues for those, and pick it up later in the project if you agree.
Gemfile
Outdated
Comment on lines
77
to
81
| gem 'capistrano', '~> 3.9', require: false | ||
| gem 'capistrano3-puma', '~> 5.0.4', require: false | ||
| gem 'capistrano3-puma', '~> 6.0', require: false | ||
| gem 'capistrano-bundler', '~> 1.1', require: false | ||
| gem 'capistrano-maintenance', '~> 1.0', require: false | ||
| gem 'capistrano-rails', '~> 1.1', require: false |
Member
There was a problem hiding this comment.
Capistrano can be removed, we don't use it anymore
| gem 'webmock', '>= 3.5' | ||
| end | ||
|
|
||
| gem 'puma' |
Member
There was a problem hiding this comment.
ETModel now uses puma 6, where the other apps use puma 7.
We can pick this up now, or note it for later.
Contributor
Author
There was a problem hiding this comment.
This is very easy to pick up now. Seems like Capistrano is what held back Puma, if Capistrano is not needed anymore we can remove it and quickly bring Puma on pair with the rest of Repos
aaccensi
force-pushed
the
update-ruby3.4
branch
from
1c63a6e to
bacce93
Compare
Fixes include moving puma to all environments, upgrading capistrano3-puma to v6 for Rack 3 compatibility, and updating spec assertions to match changed Rails 8 error messages.
Nothing to migrate to Solid Cable since it is entirely unused therefore only cleanup.
Replaces Memcache(Dalli)
aaccensi
force-pushed
the
update-ruby3.4
branch
from
bacce93 to
9dbba33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
With the goal to update Ruby/Rails stack apps to Ruby 4 and Rails 8 (etengine, etmodel, etlocal, my-etm).
Now we are making a in-between step to Ruby 3.4 to be able to run respec with deprecation warnings.
Then finally update to Rails 8.1, fix any issues and adopt the Solid Stack where relevant.
Implemented changes
Bumped the internal gems versions to use the newest commits (made Ruby 4 ready in another set of PRs).
Upgrade to Ruby 3.4 and run rspec with deprecation warnings:
Upgrade to Rails 8.1 and fix issues:
Delete Action Cable references
Configure Solid Cache (Replaced Memcached/dalli)
Note that some configuration is necessary, we added a dedicated DB for Solid Cache, that needs configuring some env vars:
Related
This is one of 5 PRs with the same purpose across the following 4 repos:
Checklist