Skip to content

Conversation

@louispt1
Copy link
Contributor

Description

Retired FinalDemand, MaxDemand and DependentSupply recursive methods. MaxDemand and DependentSupply could be retired directly, whereas for FinalDemand I had to remove it from a csv output here:

app/serializers/application_demands_serializer.rb

I also retired the domestic_dead_end? method in favour of right_dead_end?

Note that the final_demand_group still applies to a lot of nodes in ETSource. This group still seems relevant.

So far everything works well, but our plan to thoroughly test the outcomes by comparing gquery results between local and beta is still in progress.

Closes #1617

@louispt1 louispt1 requested a review from aaccensi January 15, 2026 13:42
Copy link
Contributor

@aaccensi aaccensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say is good, very hard to tell if anything is left behind but the engine seems to work fine after removing this.

I tested all the dashboard gqueries with py-etm (except dashboard_profitability that did not work for me), before and after the change and they spit the same results!

@louispt1 louispt1 marked this pull request as ready for review January 16, 2026 15:32
@louispt1 louispt1 requested a review from noracato January 16, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retire recursive methods

3 participants