Remove recursive methods and domestic dead end #1695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Retired FinalDemand, MaxDemand and DependentSupply recursive methods. MaxDemand and DependentSupply could be retired directly, whereas for FinalDemand I had to remove it from a csv output here:
I also retired the
domestic_dead_end?method in favour ofright_dead_end?Note that the final_demand_group still applies to a lot of nodes in ETSource. This group still seems relevant.
So far everything works well, but our plan to thoroughly test the outcomes by comparing gquery results between local and beta is still in progress.
Closes #1617