Remove intelligent control input sliders from scenarios

[kaskranenburgQ]

This PR solves quintel/etmodel#4490 by removing the intelligent control lighting inputs in the scenarios

Goes with:

• ETSource: Remove intelligent control input sliders from scenarios etsource#3413
• ETModel: Remove intelligent control lighting nodes and inputs etmodel#4491
• ETEngine: Remove intelligent control input sliders from scenarios #1583
• ETDataset: https://github.com/quintel/etdataset/pull/1079

[kaskranenburgQ]

This migration causes minor changes in comparison to beta, see the ii3050v2 NT Leadership scenario in which both removed sliders where set to 95%:
Beta:

Local:

I personally don't see how we could mitigate these changes, since there are no other sliders that influence the useful demand of lighting in the buildings sector. Since these changes are generally small, I feel that no extra effort is required.

[github-actions]

This pull request has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

[kndehaan]

I've updated the migration file name to be the most recent one. I agree with the conclusion that there's no way to account for the settings in the intelligent light control inputs with I migration. So the migration should just only remove the inputs from the scenarios.

[kndehaan]

Added @louispt1 as a functional reviewer.

[kndehaan]

Works as it should.

[kndehaan]

The migration will be altered, as the work for quintel/etmodel#4631 will be taken up as well, which will affect the migration.

[kndehaan]

The migration works well and shows the results that I expect from the pseudo code! The migration needs alterations on two points (this was not wrong about the migration itself, but what I found out after testing that was missing from the pseudo code). Point 1 can already be processed, point 2 I still need to figure out how this should be calculated correctly.

1. To be added to the migration
The old input buildings_useful_demand_for_appliances has been renamed to buildings_appliances_efficiency, so it needs to be checked if this input was set in a scenario and the value subsequently needs to be set for the new input name. Old input should be deleted. In pseudo code:

APPLIANCE_EFFICIENCY_OLD_KEY = 'buildings_useful_demand_for_appliances'
APPLIANCE_EFFICIENCY_NEW_KEY = 'buildings_appliances_efficiency'

if APPLIANCE_EFFICIENCY_OLD_KEY set in scenario:
  APPLIANCE_EFFICIENCY_NEW_KEY = APPLIANCE_EFFICIENCY_OLD_KEY
  delete APPLIANCE_EFFICIENCY_OLD_KEY

2. Modification in migration
There's something not going right in the use case where both demand and intelligent light inputs were set (elsif old_demand_set && intel_light_set), but that's something that goes wrong in the pseudo code (and therefore in the migration). I will try to figure out how this should be done properly, and will rewrite the pseudo code part so it can subsequently be implemented in the migration.

[aaccensi]

Point 1 can already be processed, point 2 I still need to figure out how this should be calculated correctly.

Alright, pseudo-code from point 1 has already been added to the migration. Any further changes are pending on outcome of point 2.