-
Notifications
You must be signed in to change notification settings - Fork 6
API user management documentation #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,63 @@ | ||
| const scenarioIdParam = { | ||
| name: "scenario_id", | ||
| type: "number", | ||
| description: "the scenario ID", | ||
| }; | ||
| name: "scenario_id", | ||
| type: "number", | ||
| description: "the scenario ID", | ||
| }; | ||
|
|
||
| export default { | ||
| index: { | ||
| endpoint: "/api/v3/scenarios/{scenario_id}/users", | ||
| method: "GET", | ||
| path_parameters: [scenarioIdParam], | ||
| token: { scopes: ["scenarios:delete"] }, | ||
| }, | ||
| export default { | ||
| index: { | ||
| endpoint: "/api/v3/scenarios/{scenario_id}/users", | ||
| method: "GET", | ||
| path_parameters: [scenarioIdParam], | ||
| token: { scopes: ["scenarios:delete"] }, | ||
| }, | ||
|
|
||
| update: { | ||
| endpoint: "/api/v3/scenarios/{scenario_id}/version", | ||
| method: "PUT", | ||
| path_parameters: [scenarioIdParam], | ||
| parameters: [ | ||
| { | ||
| name: "description", | ||
| type: "string", | ||
| description: "a short description of the tagged version", | ||
| }, | ||
| ], | ||
| token: { scopes: ["scenarios:delete"] }, | ||
| }, | ||
| create: { | ||
| endpoint: "/api/v3/scenarios/{scenario_id}/version", | ||
| method: "POST", | ||
| path_parameters: [scenarioIdParam], | ||
| parameters: [ | ||
| { | ||
| name: "description", | ||
| type: "string", | ||
| description: "a short description of the tagged version", | ||
| }, | ||
| ], | ||
| token: { scopes: ["scenarios:delete"] }, | ||
| }, | ||
| }; | ||
| create: { | ||
| endpoint: "/api/v3/scenarios/{scenario_id}/users", | ||
| method: "POST", | ||
| path_parameters: [scenarioIdParam], | ||
| parameters: [ | ||
| { | ||
| name: "scenario_users", | ||
| type: "array", | ||
| description: "array of user objects to add", | ||
| }, | ||
| ], | ||
| token: { scopes: ["scenarios:delete"] }, | ||
| }, | ||
|
|
||
| update: { | ||
| endpoint: "/api/v3/scenarios/{scenario_id}/users", | ||
| method: "PUT", | ||
| path_parameters: [scenarioIdParam], | ||
| parameters: [ | ||
| { | ||
| name: "scenario_users", | ||
| type: "array", | ||
| description: "array of user objects to update", | ||
| }, | ||
| ], | ||
| token: { scopes: ["scenarios:delete"] }, | ||
| }, | ||
|
|
||
| destroy: { | ||
| endpoint: "/api/v3/scenarios/{scenario_id}/users", | ||
| method: "DELETE", | ||
| path_parameters: [scenarioIdParam], | ||
| parameters: [ | ||
| { | ||
| name: "scenario_users", | ||
| type: "array", | ||
| description: "array of user objects to remove", | ||
| }, | ||
| ], | ||
| token: { scopes: ["scenarios:delete"] }, | ||
| }, | ||
|
|
||
| destroyAll: { | ||
| endpoint: "/api/v3/scenarios/{scenario_id}/users/destroy_all", | ||
| method: "DELETE", | ||
| path_parameters: [scenarioIdParam], | ||
| token: { scopes: ["scenarios:delete"] }, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that for the following added operations:
We are kind of skipping the convention of using
I understand this would bulk this page quite a lot but this drives me to another point, perhaps it would have been better to put the entire "Managing saved scenario users" section into its own page similar to how we do it for the standard scenario users? Not asking for a change, just offering my thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the thought and in general agree that some standard practices would be nice.
I decided to try and keep the docs minimal in this case, because I would hope that in the future we would remove the ability to manage the underlying scenario users completely and just manage everything via saved scenario users. Because the functionalities are for a passthrough - managing saved scenario users via an engine endpoint, I decided to just keep everything together.
TLDR:
In the long run I would propose making a 'Users' page which describes managing users (which only happens through one endpoint and at the level of saved scenarios). For now I'd rather not bog down users with extra info.