Skip to content

Horizontally scalable endpoints #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Horizontally scalable endpoints #1578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2268487
Require CID generators to be internally thread-safe
Ralith May 28, 2023
41a2a97
Use the thread-local RNG in Endpoint
Ralith May 28, 2023
53cf3d9
Move side effects out of add_connection
Ralith May 28, 2023
757043d
Adopt interior mutability pervasively in proto::Endpoint
Ralith May 28, 2023
ded8d62
Lift proto::Endpoint out of the endpoint driver mutex
Ralith May 28, 2023
c114a0c
Handle proto endpoint events directly in connection drivers
Ralith May 28, 2023
8950769
Request CIDs from the endpoint synchronously
Ralith May 29, 2023
0098628
Retire CIDs synchronously
Ralith May 29, 2023
473f5da
Factor alloc_new_identifiers call into queue_new_cids
Ralith May 29, 2023
77e0866
Propagate reset token updates to the endpoint synchronously
Ralith May 29, 2023
8e6401a
Notify endpoint of drained connections synchronously
Ralith May 29, 2023
0ba3461
Strip down ConnectionEvent to reflect its sole remaining purpose
Ralith May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions quinn-proto/src/cid_generator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ use crate::shared::ConnectionId;
use crate::MAX_CID_SIZE;

/// Generates connection IDs for incoming connections
pub trait ConnectionIdGenerator: Send {
pub trait ConnectionIdGenerator: Send + Sync {
/// Generates a new CID
///
/// Connection IDs MUST NOT contain any information that can be used by
/// an external observer (that is, one that does not cooperate with the
/// issuer) to correlate them with other connection IDs for the same
/// connection.
fn generate_cid(&mut self) -> ConnectionId;
fn generate_cid(&self) -> ConnectionId;
/// Returns the length of a CID for connections created by this generator
fn cid_len(&self) -> usize;
/// Returns the lifetime of generated Connection IDs
Expand Down Expand Up @@ -58,7 +58,7 @@ impl RandomConnectionIdGenerator {
}

impl ConnectionIdGenerator for RandomConnectionIdGenerator {
fn generate_cid(&mut self) -> ConnectionId {
fn generate_cid(&self) -> ConnectionId {
let mut bytes_arr = [0; MAX_CID_SIZE];
rand::thread_rng().fill_bytes(&mut bytes_arr[..self.cid_len]);

Expand Down
251 changes: 123 additions & 128 deletions quinn-proto/src/connection/mod.rs
View file
Open in desktop

Large diffs are not rendered by default.

Loading