Make PPS/SPS NAL structs public; Add helper methods #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quietvoid
reviewed
Mar 10, 2024
| pub use sei::SeiMessage; | ||
|
|
||
| #[derive(PartialEq, Hash, Debug, Copy, Clone)] | ||
| pub enum UnitType { |
There was a problem hiding this comment.
If you duplicate the NALU types, the constants above need to be replaced.
I don't mind switching to an enum but it would need a major version bump.
Also I think it would be better to name it NalUnitType, and remove the Nal prefix from the variant names.
I totally forgot to finalize the review, sorry this is very late.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have currently been using this library in our rtsp client to support h265 framing. In order to support this we have added made some fields public and added some helper methods. We'd like to get this merged upstream so we can get this published on crates.io