Tiniest NiT on CE ? #320
Open
Tiniest NiT on CE ? #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Immediate response when CE marked or not, ought to refer to the packet being ACK'ed.
ianswett
reviewed
Mar 2, 2025
| @@ -463,7 +463,7 @@ Threshold or max_ack_delay. Therefore, CE-marking only triggers an immediate | |||
| acknowledgement when there is a transition from non-CE-marked to CE-marked. | |||
|
|
|||
| If the Ack-Eliciting Threshold is 0, every ack-eliciting packet is immediately | |||
| acknowledged, CE marked or not. If the Ack-Eliciting Threshold | |||
| acknowledged (both when the packet was CE marked and when not). If the Ack-Eliciting Threshold | |||
There was a problem hiding this comment.
Is this better?
Suggested change
| acknowledged (both when the packet was CE marked and when not). If the Ack-Eliciting Threshold | |
| acknowledged, whether it is CE marked or not. If the Ack-Eliciting Threshold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immediate response when CE marked or not, ought to refer to the packet being ACK'ed.