Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiniest NiT on CE ? #320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tiniest NiT on CE ? #320

wants to merge 1 commit into from

Conversation

gorryfair
Copy link
Contributor

Immediate response when CE marked or not, ought to refer to the packet being ACK'ed.

Immediate response when CE marked or not, ought to refer to the packet being ACK'ed.
Copy link
Collaborator

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the existing text is fairly clear, but I tried to make it read easier in my suggestion.

@@ -463,7 +463,7 @@ Threshold or max_ack_delay. Therefore, CE-marking only triggers an immediate
acknowledgement when there is a transition from non-CE-marked to CE-marked.

If the Ack-Eliciting Threshold is 0, every ack-eliciting packet is immediately
acknowledged, CE marked or not. If the Ack-Eliciting Threshold
acknowledged (both when the packet was CE marked and when not). If the Ack-Eliciting Threshold
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this better?

Suggested change
acknowledged (both when the packet was CE marked and when not). If the Ack-Eliciting Threshold
acknowledged, whether it is CE marked or not. If the Ack-Eliciting Threshold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants