Add a hard limit on field list size #5843
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
reviewed
Jul 15, 2025
| @@ -184,6 +198,12 @@ fn merge_leaf_list_fields( | |||
| flush_group(&mut responses, &mut current_group); | |||
| } | |||
| } | |||
| if responses.len() >= get_field_list_size_limit() { | |||
| return Err(SearchError::Internal(format!( | |||
There was a problem hiding this comment.
We could return a truncated list instead
There was a problem hiding this comment.
My concern with a truncated list is that it doesn't clearly indicate that something went wrong and that results are not deterministic. This is really a short term patch to prevent excessive memory usage, but I think we should work on a proper solution that correctly prunes the long tail of "rare" fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Searchers sometime OOM when returning too many fields (~millions). This PR adds a hard limit on the number of fields that can be returned.
How was this PR tested?
Describe how you tested this PR.