Skip to content

Add tonic tls feature #5725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Add tonic tls feature #5725

merged 1 commit into from
Apr 10, 2025

Conversation

pinylin
Copy link
Contributor

@pinylin pinylin commented Mar 30, 2025

Description

When running

cargo bench --package quickwit-actors --bench bench

, noticed that the make_channel method in the quickwit-common crate not work.
It needs #[cfg(feature = "tls")] for tonic::transport::ClientTlsConfig.

How was this PR tested?

cargo bench

@rdettai rdettai enabled auto-merge (squash) April 10, 2025 09:39
@rdettai rdettai merged commit d604b37 into quickwit-oss:main Apr 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilload guilload guilload approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinylin @guilload @rdettai