-
Notifications
You must be signed in to change notification settings - Fork 452
Faster shard scaling #5679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster shard scaling #5679
Conversation
Test setup:
Observations:
|
af3a911
to
3bbfa9e
Compare
quickwit/quickwit-control-plane/src/ingest/ingest_controller.rs
Outdated
Show resolved
Hide resolved
33e28fe
to
4d93d07
Compare
fn long_term_scale_up_threshold_max_shards(&self, shard_stats: ShardStats) -> usize { | ||
(shard_stats.avg_long_term_ingestion_rate * shard_stats.num_open_shards as f32 | ||
/ self.scale_up_shards_long_term_threshold_mib_per_sec) | ||
.floor() as usize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the floor? I would have expected ceil here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it was a ceil
, it would mean that scaling up by this number of shards would get us slightly below the scale_up_shards_long_term_threshold_mib_per_sec
. For small shard counts it might get us a bit to close to scale_down_shards_threshold_mib_per_sec
f185d6a
to
d74e517
Compare
Description
Indexers return a lot of 429 when ingest rates fluctuate, even if the overall indexing capacity (~5MB/core) is note reached. This PR makes some small parameter adjustments to decrease the overall error rates on typical workloads. It will be the topic for another issue/PR to introduce the structual changes that are necessary to improve the routing strategy.
Related to #5270
How was this PR tested?
Adhoc python load testing framework: https://github.com/rdettai/qw-ingest-tests