Skip to content

SequenceReset might use wrong MsgSeqNum, message will be ignored by counterparty #344

Description

@JavaNoviceForChina

image

”generateSequenceResetIfNeeded“method:What I understand is that when the retrieved messages to be processed are less than the endseqno, for example, messages from 2 to 10 are expected to be sent, but only 2 to 6 are retrieved in persistence, and the sequence number needs to be reset to 11;However, there is a bug in the current code logic. When message 5 in 2 to 6 is an app message and 6 is an admin message, a reset message with sequence number 2 will be sent. However, the seqno expected by the other party has been reset to 6 when sending the app message with sequence number 5, which will cause the sequence number to be too low. I think the newbegin variable should be the sequence number expected by the current party, so it should be changed to Newbegin is defined above the for loop and is assigned the current sent message sequence number + 1 at appmessage justsent = true

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions