Skip to content

Moved source files to relevant folders #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 58 additions & 56 deletions src/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,65 +1,67 @@
AUTOMAKE_OPTIONS = subdir-objects

lib_LTLIBRARIES =

LIBDSPRPC_CFLAGS = -fno-short-enums -U_DEBUG -DARM_ARCH_7A -DLE_ENABLE -DNO_HAL -DENABLE_UPSTREAM_DRIVER_INTERFACE -DUSE_SYSLOG -I$(top_srcdir)/inc

LIBDSPRPC_SOURCES = \
fastrpc_apps_user.c \
fastrpc_perf.c \
fastrpc_pm.c \
fastrpc_config.c \
fastrpc_async.c \
fastrpc_mem.c \
fastrpc_notif.c \
fastrpc_latency.c \
fastrpc_ioctl.c \
fastrpc_log.c \
fastrpc_procbuf.c \
fastrpc_cap.c \
log_config.c \
dspsignal.c \
fastrpc_apps_core.c \
profile/fastrpc_perf.c \
control/fastrpc_pm.c \
control/fastrpc_config.c \
control/fastrpc_async.c \
memory/fastrpc_mem.c \
control/fastrpc_notif.c \
profile/fastrpc_latency.c \
control/fastrpc_ioctl.c \
debug/fastrpc_log.c \
control/fastrpc_procbuf.c \
control/fastrpc_cap.c \
debug/log_config.c \
daemon/dspsignal.c \
dspqueue/dspqueue_cpu.c \
dspqueue/dspqueue_rpc_stub.c \
listener_android.c \
apps_std_imp.c \
apps_mem_imp.c \
apps_mem_skel.c \
rpcmem_linux.c \
adspmsgd.c \
adspmsgd_printf.c \
std.c \
std_path.c \
std_mem.c \
std_dtoa.c \
std_strlprintf.c \
BufBound.c \
std_SwapBytes.c \
smath.c \
atomic.c \
cae.c \
platform_libs.c \
pl_list.c \
gpls.c \
remotectl_stub.c \
remotectl1_stub.c \
adspmsgd_apps_skel.c \
adspmsgd_adsp_stub.c \
adspmsgd_adsp1_stub.c \
apps_remotectl_skel.c \
adsp_current_process_stub.c \
adsp_current_process1_stub.c \
adsp_listener_stub.c \
adsp_listener1_stub.c \
apps_std_skel.c \
adsp_perf_stub.c \
adsp_perf1_stub.c \
mod_table.c
listener/listener_android.c \
listener/apps_std_imp.c \
Copy link
Contributor

@quic-bkumar quic-bkumar Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since apps_std is unrelated to the listener, we can relocate apps_std_imp.c to the file folder, as it contains the implementation for file system access.

memory/apps_mem_imp.c \
dspInterface/apps_mem_skel.c \
Copy link
Contributor

@quic-bkumar quic-bkumar Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would be beneficial to consolidate all apps_mem related files into a single folder that represents all memory accesses from the DSP.

memory/rpcmem_linux.c \
debug/adspmsgd.c \
debug/adspmsgd_printf.c \
common/std.c \
common/std_path.c \
common/std_mem.c \
common/std_dtoa.c \
common/std_strlprintf.c \
common/BufBound.c \
common/std_SwapBytes.c \
common/smath.c \
common/atomic.c \
common/cae.c \
common/platform_libs.c \
common/pl_list.c \
common/gpls.c \
dspInterface/remotectl_stub.c \
dspInterface/remotectl1_stub.c \
dspInterface/adspmsgd_apps_skel.c \
Copy link
Contributor

@quic-bkumar quic-bkumar Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like with memory, I think it would be beneficial to group this file under the debug folder.

dspInterface/adspmsgd_adsp_stub.c \
dspInterface/adspmsgd_adsp1_stub.c \
dspInterface/apps_remotectl_skel.c \
dspInterface/adsp_current_process_stub.c \
Copy link
Contributor

@quic-rnallago quic-rnallago Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would be more effective to group all app_skel and dsp_stub files into separate folders under dsp interface for better differentiation.

dspInterface/adsp_current_process1_stub.c \
dspInterface/adsp_listener_stub.c \
dspInterface/adsp_listener1_stub.c \
dspInterface/apps_std_skel.c \
Copy link
Contributor

@quic-bkumar quic-bkumar Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grouping under "file" folder would be beneficial.

dspInterface/adsp_perf_stub.c \
dspInterface/adsp_perf1_stub.c \
common/mod_table.c

LIBDEFAULT_LISTENER_SOURCES = \
adsp_default_listener.c \
adsp_default_listener_stub.c \
adsp_default_listener1_stub.c \
std.c \
std_mem.c
listener/adsp_default_listener.c \
dspInterface/adsp_default_listener_stub.c \
dspInterface/adsp_default_listener1_stub.c \
common/std.c \
common/std_mem.c

if ANDROID_CC
USE_LOG = -llog
Expand Down Expand Up @@ -108,21 +110,21 @@ libsdsp_default_listener_la_CFLAGS = $(SDSP_CFLAGS) -DUSE_SYSLOG
bin_PROGRAMS = adsprpcd cdsprpcd sdsprpcd

adsprpcddir = $(libdir)
adsprpcd_SOURCES = adsprpcd.c
adsprpcd_SOURCES = daemon/adsprpcd.c
adsprpcd_DEPENDENCIES = libadsp_default_listener.la
adsprpcd_CFLAGS = -I$(top_srcdir)/inc -DDEFAULT_DOMAIN_ID=0 -DUSE_SYSLOG -DNO_HAL
adsprpcd_LDADD = -ldl $(USE_LOG)


cdsprpcddir = $(libdir)
cdsprpcd_SOURCES = cdsprpcd.c
cdsprpcd_SOURCES = daemon/cdsprpcd.c
cdsprpcd_DEPENDENCIES = libcdsp_default_listener.la
cdsprpcd_CFLAGS = -I$(top_srcdir)/inc -DDEFAULT_DOMAIN_ID=3 -DUSE_SYSLOG -DNO_HAL
cdsprpcd_LDADD = -ldl $(USE_LOG)


sdsprpcddir = $(libdir)
sdsprpcd_SOURCES = cdsprpcd.c
sdsprpcd_SOURCES = daemon/cdsprpcd.c
sdsprpcd_DEPENDENCIES = libsdsp_default_listener.la
sdsprpcd_CFLAGS = -I$(top_srcdir)/inc -DDEFAULT_DOMAIN_ID=2 -DUSE_SYSLOG -DNO_HAL
sdsprpcd_LDADD = -ldl $(USE_LOG)
Expand Down
8 changes: 4 additions & 4 deletions src/adsprpc_blacklist.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
src:*/adspmsgd_apps_skel.c
src:*/apps_mem_skel.c
src:*/apps_remotectl_skel.c
src:*/apps_std_skel.c
src:*/dspInterface/adspmsgd_apps_skel.c
src:*/dspInterface/apps_mem_skel.c
src:*/dspInterface/apps_remotectl_skel.c
src:*/dspInterface/apps_std_skel.c
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.