Refactor: Generalize Code by Removing Vendor and Android-Specific Elements #154
Conversation
| @@ -3548,12 +3483,6 @@ static int open_shell(int domain_id, apps_std_FILE *fh, int unsigned_shell) { | |||
| if (domain == SDSP_DOMAIN_ID && fh != NULL) { | |||
| nErr = AEE_SUCCESS; | |||
| *fh = -1; | |||
| } else { | |||
| FARF(ERROR, | |||
There was a problem hiding this comment.
should not completely remove the error log
There was a problem hiding this comment.
The error log contains vendor-specific location macros.
There was a problem hiding this comment.
So, the error log needs to be fixed rather than being completely removed.
There was a problem hiding this comment.
Okay, I'll only be logging the paths that have been actually checked.
| #endif | ||
|
|
||
| #include <string.h> | ||
| #include <errno.h> |
There was a problem hiding this comment.
can you highlight what is changed in this file?
There was a problem hiding this comment.
Nothing has changed in this file.
src/fastrpc_apps_user.c
Outdated
| "vendor.fastrpc.debug.systrace", | ||
| "vendor.fastrpc.debug.pddump", | ||
| "persist.vendor.fastrpc.process.attrs", | ||
| "ro.build.type"}; | ||
| const char *ANDROID_DEBUG_VAR_NAME[] = {"fastrpc.process.attrs", |
There was a problem hiding this comment.
This is also Android-specific var and was missed
There was a problem hiding this comment.
Thanks for pointing that out. I am working on the cleanup and will include it in the next patch.
quic-vkatoch
force-pushed
the
code-cleanup
branch
from
5ad182f to
e92d2c8
Compare
src/fastrpc_apps_user.c
Outdated
| @@ -241,26 +230,6 @@ const char *ENV_DEBUG_VAR_NAME[] = {"FASTRPC_PROCESS_ATTRS", | |||
| "FASTRPC_DEBUG_PDDUMP", | |||
| "FASTRPC_PROCESS_ATTRS_PERSISTENT", | |||
| "ro.debuggable"}; | |||
There was a problem hiding this comment.
ro.debuggable is also an Android definition.
There was a problem hiding this comment.
I'll check and remove it.
|
Please check if you can break the change into multiple commits instead of a single commit. |
definitions in apps_std_internal.h Signed-off-by: Vinayak Katoch <[email protected]>
conditional include for systrace in fastrpc_trace.h Signed-off-by: Vinayak Katoch <[email protected]>
listener.c, and update function names in listener.c Signed-off-by: Vinayak Katoch <[email protected]>
update Makefile.am, and update PROPERTY_VALUE_MAX definition. Signed-off-by: Vinayak Katoch <[email protected]>
fastrpc_apps_user.c Signed-off-by: Vinayak Katoch <[email protected]>
quic-vkatoch
force-pushed
the
code-cleanup
branch
from
e92d2c8 to
66cba44
Compare
for all build types. Signed-off-by: Vinayak Katoch <[email protected]>
| #endif | ||
| } | ||
| if (persist_buf.buf == NULL && debug_build_type) { | ||
| if (persist_buf.buf == NULL) { |
There was a problem hiding this comment.
These are separate changes. Why are you squashing them into a single commit?
There was a problem hiding this comment.
I have separated the changes into multiple commits and it's no longer a single commit. I'm checking if it could be separated any further.
Refactored the codebase to remove vendor-specific and Android-specific elements, making the project more general and platform-independent.