Free memory allocated for storing pdname and runtime logs #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a memory leak of 120 bytes every time handle open is requested for staticpd and function returns without freeing memory allocated for storing pdname in uri. Similarly 256 bytes of memory leaked with runtime logging buffer. Free this allocated memory before returning from function. Signed-off-by: Ansa Ahmed <[email protected]>
quic-bkumar
approved these changes
Jan 21, 2025
quic-mtharu
reviewed
Jan 23, 2025
| @@ -1660,7 +1660,7 @@ int remote_handle_open_domain(int domain, const char *name, remote_handle *ph, | |||
| } else if (!std_strncmp(pdName, "oispd", std_strlen("oispd"))) { | |||
| hlist[domain].dsppd = OIS_STATICPD; | |||
| } | |||
| return AEE_SUCCESS; | |||
| goto free_buffer; | |||
There was a problem hiding this comment.
Can't we use 'bail' only instead of new 'free_buffer' jump instructions ?
Minimize 'goto' statements for better readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a memory leak of 120 bytes every time handle open is requested for staticpd and function returns without freeing memory allocated for storing pdname in uri. Similarly 256 bytes of memory leaked with runtime logging buffer. Free this allocated memory before returning from function.