Reading mxfp6_matmul for QNN Compilation path from compile API arguments #499
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Agrawal <[email protected]>
shubhagr-qc
requested review from
quic-rishinr,
ochougul,
quic-hemagnih and
quic-amitraj
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mxfp6_matmul as a recognized argument in QEFFBaseModel::_compile. Its required because for VLM models, qefficient is over-writing mxfp6 value as false for vision case and to use the same value for QNN we are reading it from compile API arguments and made mxfp6 matmul parameter as immutable from qnn_config.json.