[QEff. Finetune] Fixed reporting of single value of loss and ppl across devices. #496
+155
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
quic-meetkuma
commented
Jul 7, 2025
quic-meetkuma
commented
- Fixed reporting of single value of loss and ppl across devices.
- Minor refactoring changes and variable name changes to make it consistent.
quic-swatia
reviewed
Jul 7, 2025
quic-meetkuma
requested review from
quic-rishinr,
ochougul,
quic-hemagnih and
quic-amitraj
as code owners
quic-mamta
reviewed
Jul 8, 2025
quic-mamta
approved these changes
Jul 9, 2025
quic-mamta
reviewed
Jul 9, 2025
quic-meetkuma
changed the title
quic-meetkuma
force-pushed
the
jitender_fixes_v2
branch
from
e3df770 to
acade4d
Compare
quic-mamta
reviewed
Jul 10, 2025
quic-mamta
reviewed
Jul 10, 2025
quic-swatia
reviewed
Jul 10, 2025
quic-meetkuma
force-pushed
the
jitender_fixes_v2
branch
from
41a8f64 to
325e37e
Compare
quic-swatia
approved these changes
Jul 15, 2025
Signed-off-by: meetkuma <[email protected]>
Signed-off-by: meetkuma <[email protected]>
Signed-off-by: meetkuma <[email protected]>
Signed-off-by: meetkuma <[email protected]>
quic-meetkuma
force-pushed
the
jitender_fixes_v2
branch
2 times, most recently
from
76f7a67 to
b7401c4
Compare
Signed-off-by: meetkuma <[email protected]>
Signed-off-by: meetkuma <[email protected]>
quic-meetkuma
force-pushed
the
jitender_fixes_v2
branch
from
b7401c4 to
7211905
Compare
Signed-off-by: meetkuma <[email protected]>
Signed-off-by: meetkuma <[email protected]>
quic-mamta
reviewed
Jul 16, 2025
quic-mamta
reviewed
Jul 16, 2025
| 0.6566, # expected_train_loss | ||
| 0.5055, # expected_train_metric | ||
| 0.6188, # expected_eval_loss | ||
| 0.6904, # expected_eval_metric |
There was a problem hiding this comment.
can we change intermediate_step_save at line 85 and other places to 10, we don't need to save the weights for testing after each step.
Signed-off-by: meetkuma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.