-
Notifications
You must be signed in to change notification settings - Fork 45
Bug fix for spdTransform #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cbda36
to
62a873c
Compare
62a873c
to
e1cbc00
Compare
ochougul
reviewed
Jun 23, 2025
e1cbc00
to
200267a
Compare
9decc20
to
65cf318
Compare
Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Dipankar Sarkar <[email protected]>
65cf318
to
e4b335b
Compare
ochougul
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving now. But this needs to be handled in a cleaner way later.
by deepcopying kwargs
, and hashing the kwargs
instead of pretrained_model_name_or_path
quic-rishinr
approved these changes
Jun 27, 2025
qcdipankar
added a commit
to qcdipankar/efficient-transformers
that referenced
this pull request
Jul 2, 2025
Added fix for spdtransform due to change in hash --------- Signed-off-by: Dipankar Sarkar <[email protected]>
qcdipankar
added a commit
to qcdipankar/efficient-transformers
that referenced
this pull request
Jul 2, 2025
Added fix for spdtransform due to change in hash --------- Signed-off-by: Dipankar Sarkar <[email protected]>
qcdipankar
added a commit
to qcdipankar/efficient-transformers
that referenced
this pull request
Jul 2, 2025
Added fix for spdtransform due to change in hash --------- Signed-off-by: Dipankar Sarkar <[email protected]>
quic-swatia
pushed a commit
to quic-swatia/efficient-transformers
that referenced
this pull request
Jul 8, 2025
Added fix for spdtransform due to change in hash --------- Signed-off-by: Dipankar Sarkar <[email protected]>
quic-amitraj
pushed a commit
that referenced
this pull request
Jul 10, 2025
Added fix for spdtransform due to change in hash --------- Signed-off-by: Dipankar Sarkar <[email protected]> Signed-off-by: Amit Raj <[email protected]>
quic-amitraj
pushed a commit
that referenced
this pull request
Jul 10, 2025
Added fix for spdtransform due to change in hash --------- Signed-off-by: Dipankar Sarkar <[email protected]> Signed-off-by: Amit Raj <[email protected]>
quic-amitraj
pushed a commit
that referenced
this pull request
Jul 10, 2025
Added fix for spdtransform due to change in hash --------- Signed-off-by: Dipankar Sarkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix for spdtransform due to change in hash