Skip to content

Bug fix for spdTransform #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2025
Merged

Conversation

qcdipankar
Copy link
Contributor

Added fix for spdtransform due to change in hash

@qcdipankar qcdipankar force-pushed the spdtransform_fixes branch 2 times, most recently from 9cbda36 to 62a873c Compare June 20, 2025 09:24
@qcdipankar qcdipankar self-assigned this Jun 20, 2025
@qcdipankar qcdipankar force-pushed the spdtransform_fixes branch from 62a873c to e1cbc00 Compare June 20, 2025 18:12
@qcdipankar qcdipankar force-pushed the spdtransform_fixes branch from e1cbc00 to 200267a Compare June 24, 2025 05:09
@qcdipankar qcdipankar removed the request for review from quic-amitraj June 25, 2025 03:57
@qcdipankar qcdipankar force-pushed the spdtransform_fixes branch from 9decc20 to 65cf318 Compare June 26, 2025 03:49
Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Dipankar Sarkar <[email protected]>
@qcdipankar qcdipankar force-pushed the spdtransform_fixes branch from 65cf318 to e4b335b Compare June 26, 2025 03:49
Copy link
Contributor

@ochougul ochougul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now. But this needs to be handled in a cleaner way later.
by deepcopying kwargs, and hashing the kwargs instead of pretrained_model_name_or_path

@quic-rishinr quic-rishinr merged commit 77cfb29 into quic:main Jun 27, 2025
4 checks passed
qcdipankar added a commit to qcdipankar/efficient-transformers that referenced this pull request Jul 2, 2025
Added fix for spdtransform due to change in hash

---------

Signed-off-by: Dipankar Sarkar <[email protected]>
qcdipankar added a commit to qcdipankar/efficient-transformers that referenced this pull request Jul 2, 2025
Added fix for spdtransform due to change in hash

---------

Signed-off-by: Dipankar Sarkar <[email protected]>
qcdipankar added a commit to qcdipankar/efficient-transformers that referenced this pull request Jul 2, 2025
Added fix for spdtransform due to change in hash

---------

Signed-off-by: Dipankar Sarkar <[email protected]>
quic-swatia pushed a commit to quic-swatia/efficient-transformers that referenced this pull request Jul 8, 2025
Added fix for spdtransform due to change in hash

---------

Signed-off-by: Dipankar Sarkar <[email protected]>
quic-amitraj pushed a commit that referenced this pull request Jul 10, 2025
Added fix for spdtransform due to change in hash

---------

Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
quic-amitraj pushed a commit that referenced this pull request Jul 10, 2025
Added fix for spdtransform due to change in hash

---------

Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
quic-amitraj pushed a commit that referenced this pull request Jul 10, 2025
Added fix for spdtransform due to change in hash

---------

Signed-off-by: Dipankar Sarkar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants