replacing the deprecated input-file of qaic-runner with json-input #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: quic-morteza <[email protected]>
|
Your commit has no description. The subject has spelling errors. The SOB is invalid |
|
Why are we merging 1.19 content on the 1.17 branch? |
quic-jhugo
reviewed
May 21, 2025
| @@ -538,4 +546,4 @@ def parse_args(): | |||
|
|
|||
| if __name__ == "__main__": | |||
| args = parse_args() | |||
| main(args) | |||
| main(args) | |||
There was a problem hiding this comment.
What did you do here? The diff looks like no change
quic-jhugo
reviewed
May 21, 2025
| cmd_elements.extend(["-i", data_file]) | ||
|
|
||
| # for data_file in data_files: | ||
| # cmd_elements.extend(["-i", data_file]) |
There was a problem hiding this comment.
Why leave dead code in? You could just as easily remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --input-file option of qaic-runner has been deprecated in SDK versions later than 1.19. The updated approach uses the --aic-batch-json-input argument to pass inputs. The new scripts are compatible with both pre- and post-1.19 SDK releases.