Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#57: Soft Validation #59

Merged
merged 2 commits into from
Sep 27, 2023
Merged

#57: Soft Validation #59

merged 2 commits into from
Sep 27, 2023

Conversation

MHajoha
Copy link
Member

@MHajoha MHajoha commented Sep 21, 2023

Baut auf #56 auf.

Ich habe es doch hinbekommen, auf die Validierungslogik des Browsers (und dessen Lokalisierung!) zurückzugreifen, wenn auch nur mittelmäßig elegant: Es werden kurz per JS die Standard-Attribute gesetzt, dann validiert, und dann die Attribute wieder entfernt.

Closes #57

Base automatically changed from question-ui-attempt-start to dev September 27, 2023 15:22
Adds bootstrap classes to question inputs to roughly emulate Moodle's look-and-feel.
We mustn't prevent form submission, but we still want to give some feedback to the user.

Closes #57
Copy link
Contributor

@MartinGauk MartinGauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nach der Annahme von #56 musste ich hier rebasen. Die Checks scheitern nun, aber in #60 wird das behoben.

@MartinGauk MartinGauk merged commit 240eaed into dev Sep 27, 2023
@MartinGauk MartinGauk deleted the soft-validation branch September 27, 2023 15:31
@MHajoha MHajoha mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question UI: Soft Validation
2 participants