Skip to content

feat: environment property for Attempt #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

Conversation

janbritz
Copy link
Contributor

Closes #194

Statt die Version zu hardcoden, greife ich über $CFG->branch auf den Branch-Namen zu, konvertiere diesen dann zum Integer und übergebe ihn dann der Attempt-Klasse.

Bisher scheint $CFG->branch immer eine Zahl gewesen zu sein, sollte sich das ändern, muss die entsprechende Stelle angepasst werden.

@janbritz janbritz requested review from MartinGauk and MHajoha July 10, 2025 13:53
@janbritz janbritz force-pushed the feat/environment-property branch from c8d2a64 to 529e2e3 Compare July 22, 2025 13:07
@janbritz janbritz merged commit 8ffe260 into dev Jul 22, 2025
0 of 6 checks passed
@janbritz janbritz deleted the feat/environment-property branch July 22, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env in JS-Attempt
2 participants