fix: question edit form #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHajoha
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falls man das Paket einer bereits gespeicherten QuestionPy-Frage wechseln und anschließend, ohne ein neues Paket auszuwählen, die Frage speichern will, wurde die Question-Edit-Form mit dem Paket angezeigt und nicht der Such-Container mit einer "Required"-Nachricht. Die bestehende Lösung hat hier durch Zufall funktioniert, da
$question->qpy_package_hashimmer auf''gesetzt wurde - in$this->currentdatagibt es nie die Keysqpy_package_hash,qpy_package_file_hashundqpy_package_selected.Das führte aber dazu, das beim Schmeißen von (Custom-)Validation-Errors, dieser Branch übersprungen wurde und das deshalb ein Request-Error angezeigt wurde.