-
Notifications
You must be signed in to change notification settings - Fork 10
Stabilising changes for version 3.0.0 #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amunra
wants to merge
25
commits into
main
Choose a base branch
from
v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
…ts for it easy, wrote tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is about tying up loose ends for a stable v. 3.0.0 of the client.
If we get feedback, we should add any extra fixup to the list below.
Task list
PyArray_ISCARRAY_RO
returns true, it should call just callline_sender_buffer_column_f64_arr_row_major
.are default strides or not.
I've tested back to Numpy 1.26, but older versions may work as well.
Once found, update
pyproject.toml
, then:Buffer
Python tests, across differentversions of NumPy.
export TEST_QUESTDB_PATCH_PATH=1
python3 test/test.py -v TestBufferProtocolVersionV2
use
uv
: https://docs.astral.sh/uv/getting-started/installation/Then run
uv run --with 'numpy==1.26.0' test/test.py -v TestBufferProtocolVersionV2
See: https://docs.astral.sh/uv/guides/scripts/#running-a-script-with-dependencies
uv
tool installs Python packages much faster than Python'sdefault
pip
tool. It's a really cool tool, worth learning about.There's no point doing this cross-platforms.
version.
versions. This is just to ensure that we don't regress the code in the future.
datetime.datetime
in Python Sphinx API docs./proj clean && ./proj build && ./proj doc
to regenerate the docsdatetime
which is only imported inCython and not in Python, so the type can't be found.
numpy.ndarray
in the docs../proj doc 1
to launch docs in the web browser.SyntaxWarning
in the tests:version of QuestDB supports arrays.
My guess is that it is going to be 8.4.0, but we need to confirm this.
(I've also added this todo to the Rust/C/C++ client TODO list.)
pick up the latest version of QuestDB and run protocol version 2 tests against
the server. We should also retain a CI test run that runs
against an older version of QuestDB (e.g. 8.3.3) to ensure that we don't
introduce regressions against protocol version 1.
README.rst
.Tandem PR
Related
c-questdb-client
PR: questdb/c-questdb-client#105