Skip to content

chore(nodejs): js doc #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Aug 7, 2025
Merged

chore(nodejs): js doc #51

merged 46 commits into from
Aug 7, 2025

Conversation

glasstiger
Copy link
Collaborator

@glasstiger glasstiger commented Jul 31, 2025 •
edited
Loading

Updated documentation.

Requires #50

glasstiger added a commit that referenced this pull request Jul 31, 2025
@glasstiger
add some js doc, mostly copied from #51
b0ef27b
@glasstiger glasstiger mentioned this pull request Jul 31, 2025
Merged
Base automatically changed from arrays_support to main August 6, 2025 17:35
puzpuzpuz
puzpuzpuz reviewed Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@puzpuzpuz puzpuzpuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs/scripts/prettify/Apache-License-2.0.txt file added by this PR is empty. Is that a leftover?

@glasstiger
Copy link
Collaborator Author

The docs/scripts/prettify/Apache-License-2.0.txt file added by this PR is empty. Is that a leftover?

This was added by Claude, did not even realise that it was empty.
I will just remove it.

@glasstiger
Copy link
Collaborator Author

The docs/scripts/prettify/Apache-License-2.0.txt file added by this PR is empty. Is that a leftover?

This was added by Claude, did not even realise that it was empty. I will just remove it.

Nope, looks like the file is generated by jsdoc, and it is not empty locally.
Must be a git thing... it does not even come up in the diff.
image

@puzpuzpuz puzpuzpuz self-requested a review August 7, 2025 12:00
@glasstiger glasstiger merged commit e54ca74 into main Aug 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glasstiger @mtopolnik @puzpuzpuz