Make default interactions configurable as @Input properties #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- re-instantiate raster when source change - add TileEvent(s) on XYZ and OSM - add wrapX to ArcGISRest - add example desciption
BREAKING CHANGE: `ol` peer dep is now `~7.5.2` BREAKING CHANGE: see all breaking changes from `ol` `7.0.0` (https://github.com/openlayers/openlayers/blob/main/changelog/upgrade-notes.md#700) BREAKING CHANGE: see all breaking changes from `ol` `7.1.0` (https://github.com/openlayers/openlayers/blob/main/changelog/upgrade-notes.md#710) BREAKING CHANGE: see all breaking changes from `ol` `7.2.0` (https://github.com/openlayers/openlayers/blob/main/changelog/upgrade-notes.md#720) BREAKING CHANGE: see all breaking changes from `ol` `7.5.0` (https://github.com/openlayers/openlayers/blob/main/changelog/upgrade-notes.md#750)
BREAKING CHANGE: Angular 14 is no more supported
BREAKING CHANGE: `ol` peer dep is now `8.2.0` BREAKING CHANGE: see all breaking changes from `ol` `8.0.0` (https://github.com/openlayers/openlayers/blob/main/changelog/upgrade-notes.md#800)
BREAKING CHANGE: Angular 15 is no more supported
BREAKING CHANGE: `ol` peer dep is now `~9.2.4` BREAKING CHANGE: see all breaking changes from `ol` `9.0.0` (https://github.com/openlayers/openlayers/blob/main/changelog/v9.0.0.md)
jeremy-eychenne
requested changes
Jun 4, 2025
There was a problem hiding this comment.
Thank you for your contribution!
-
As of automatic changelog generation, can you please use conventional commits for commits please?
-
This code does not compile because Input import is missing
-
Are you sure inputs have effects on interaction configuration? I think we should add this as param when calling defaults()
Comment on lines
+12
to
+33
| @Input() | ||
| altShiftDragRotate: boolean; | ||
| @Input() | ||
| onFocusOnly: boolean; | ||
| @Input() | ||
| doubleClickZoom: boolean; | ||
| @Input() | ||
| keyboard: boolean; | ||
| @Input() | ||
| mouseWheelZoom: boolean; | ||
| @Input() | ||
| shiftDragZoom: boolean; | ||
| @Input() | ||
| dragPan: boolean; | ||
| @Input() | ||
| pinchRotate: boolean; | ||
| @Input() | ||
| pinchZoom: boolean; | ||
| @Input() | ||
| zoomDelta: number; | ||
| @Input() | ||
| zoomDuration: number; |
There was a problem hiding this comment.
Is it possible to update typings accordingly to OpenLayers please?
|
Hi, as we just merged If this PR remains unchanged within 3 months, we will automatically close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.